Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Site hanged if Discount products with these facets by 5% is active #16

Open
hkjeffchan opened this issue Jun 26, 2020 · 3 comments
Open

Site hanged if Discount products with these facets by 5% is active #16

hkjeffchan opened this issue Jun 26, 2020 · 3 comments

Comments

@hkjeffchan
Copy link

The shop hanged if discount is applied with facet rules.

Tried firefox and chrome with the latest verison.
@michaelbromley
Copy link
Member

Reproduction:

  1. Create a Promotion with 5% off all products with the "photo" facetValue
  2. In the demo storefront, add a camera to the order
  3. Browser hangs.

Most likely an infinite change-detection loop in Angular.

@talesmgodois
Copy link

I am trying to simulate here. But Looks like it's fine. is order the same as Cart?

@michaelbromley
Copy link
Member

@talesmgodois Yes, Order is the name of the entity used by the server, whereas "Cart" is used in the storefront as a more familiar term for customers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@hkjeffchan @talesmgodois @michaelbromley