Add type definitions #102
Open
Add type definitions #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds the type definitions for the library so that users don't have to stub it out when using this in typescript.
|
Not sure why those builds failed – I didn't change any files related to builds. @veltman? |
|
is there any reason not to use this? |
|
|
HannesGitH
added a commit
to HannesGitH/flubber2
that referenced
this pull request
Oct 1, 2022
|
Perhaps add the type definitions to DefinitelyTyped as well? |
|
What needs to be done to get this merged? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the type definitions for the library so that users don't have to stub it out when using this in typescript.
fixes #100