Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor issue in the ordering of expected and actual arguments in error message #9

Open
jxofficial opened this issue Sep 21, 2021 · 0 comments

Comments

@jxofficial
Copy link

jxofficial commented Sep 21, 2021

In this line, it makes more sense for it to be fmt.Errorf("Expected infohash to be %x but got %x", infoHash, res.InfoHash), where the expected hash is the original hash as provided by the requesting client.

return nil, fmt.Errorf("Expected infohash %x but got %x", res.InfoHash, infohash)

@jxofficial jxofficial changed the title Minor issue in the ordering of expected and actual params in error message Minor issue in the ordering of expected and actual arguments in error message Sep 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant