Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task more config #919

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Task more config #919

wants to merge 23 commits into from

Conversation

royfalk
Copy link
Contributor

@royfalk royfalk commented Nov 26, 2024

Primarily, this now allows the player to set certain factors for fuel, reactor, etc.
This is complemented by an Assets PR.

Code Changes:

Refactor some stuff in main
@royfalk royfalk self-assigned this Nov 26, 2024
@royfalk
Copy link
Contributor Author

royfalk commented Dec 3, 2024

Can I get a review of the branch?

Copy link
Contributor

@evertvorster evertvorster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi there!

Just built this branch, and the corresponding branch of Assets.
When starting a new game, and then going straight into Ship Info, I can see the turning response is 0.

I thought that this was introduced by the other branch where the more standard boost libraries were used.

However, here it is now. When you just launch, this turning response of 0 does not seem to have an effect on the game. However, if you save the game and then reload it, now you have no flight controls. Ie: you cannot turn your ship in any direction.

When testing against the master branches of Assets and Engine, this behavior is also present.

Do you see the same thing? I could have sworn that the last time I tested master branches, this was not the case. Can you test and see if you see the same thing?

@royfalk
Copy link
Contributor Author

royfalk commented Dec 7, 2024

When starting a new game, and then going straight into Ship Info, I can see the turning response is 0.

I assume this is #924 . Given we have a fix in the works, let's ignore it here.

Copy link
Contributor

@evertvorster evertvorster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issues I have seen in this branch are indeed gone, and now everything looks perfect.

@royfalk
Copy link
Contributor Author

royfalk commented Dec 9, 2024

Fixed the issue you mentioned in vegastrike/Assets-Production#137.
However, note that actual figure reported by fuel does not make sense. We'll need to adjust this number further for all ships.

We'll also need to document everything and possibly create a guide of some kind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants