Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ship_info and Upgrade_info in python do not apply factors #907

Open
royfalk opened this issue Nov 14, 2024 · 0 comments
Open

Ship_info and Upgrade_info in python do not apply factors #907

royfalk opened this issue Nov 14, 2024 · 0 comments
Assignees
Milestone

Comments

@royfalk
Copy link
Contributor

royfalk commented Nov 14, 2024

With the introduction of #895, the configuration in C++ has factors for reactor, capacitor, ftl_capacitor, etc.
When displaying their properties, these factors need to be applied.

However, the code we are using in ship view to transfer the ship stats is the same code as save ship to file. This applies the factor in reverse, or multiple saves would apply the factor multiple times. We need to expose these factors to python by porting them to config.json.

The same applies for upgrade view, where the configuration is read directly from units.json.

@royfalk royfalk self-assigned this Nov 14, 2024
@BenjamenMeyer BenjamenMeyer added this to the 0.10.x milestone Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants