Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mac/Windows Release Uploader #858

Open
BenjamenMeyer opened this issue May 4, 2024 · 5 comments
Open

Mac/Windows Release Uploader #858

BenjamenMeyer opened this issue May 4, 2024 · 5 comments

Comments

@BenjamenMeyer
Copy link
Member

We build a number of different artifacts as part of our release process. However, the release upload action used is only supported on Linux. We need an equivalent for Mac and Windows so that we can finish the release process for 0.9.x.

@BenjamenMeyer
Copy link
Member Author

The one we use on Linux should easily port to Mac as its a simple Bash script; the maintainer though doesn't have Mac/windows so doesn't want to support anything other than Linux (can't blame them). If we wanted to migrate it we could fork and add Mac support (easy) and Windows support (port to PowerShell). WOuldn't be hard, but we'd have to maintain it.

The ones provided by GitHub seem to be more oriented around PRs and have auto-expiry on the uploads though the URL is similar to what GH Action we use on Linux uses so not sure.

Are there others that would work?

@stephengtuggy
Copy link
Contributor

Can we just use the upload-artifacts action that we use for test results?

@BenjamenMeyer
Copy link
Member Author

Can we just use the upload-artifacts action that we use for test results?

that seems to have a 90-day expiration from what I can tell - meaning we'd lose the artifacts after 90 days. Other than that I see no reason not to - and I could very well have misread something about that too. It would certainly be nice to use the GH provided actions for things like this, and we can certainly try it with the alphas/betas and see what happens.

@daviewales
Copy link
Contributor

It's definitely possible to upload build files to releases.
This might help?

https://github.com/softprops/action-gh-release?tab=readme-ov-file#%EF%B8%8F-uploading-release-assets

@BenjamenMeyer
Copy link
Member Author

NOTE: In looking at the tooling we're using for Linux vs the upload-artifacts tooling - they're very very similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants