Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vegas fails to work when circe 0.9.3 is imported in Zeppelin #156

Open
dankolesnikov opened this issue Sep 15, 2018 · 4 comments
Open

Vegas fails to work when circe 0.9.3 is imported in Zeppelin #156

dankolesnikov opened this issue Sep 15, 2018 · 4 comments

Comments

@dankolesnikov
Copy link

Vegas doesn't graph if the user imports circe 0.9.3 in Zeppelin.

To reproduce in Zeppelin, import the following in the spark interpreter and run a sample Vegas example:

  • org.vegas-viz:vegas_2.11:0.3.11
  • io.circe:circe-core_2.11:0.9.3

Throws exception:

java.lang.NoSuchMethodError: io.circe.Printer.copy(ZZLjava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;Ljava/lang/String;)Lio/circe/Printer;
  at vegas.spec.package$.<init>(package.scala:11)
  at vegas.spec.package$.<clinit>(package.scala)
  at vegas.DSL.ExtendedUnitSpecBuilder.toJson(SpecDSL.scala:55)
  at vegas.render.ShowHTML.apply(ShowRender.scala:19)
  at vegas.render.ShowHTML.apply(ShowRender.scala:18)
  at vegas.DSL.SpecBuilder$SpecBuilderRenderOps$.show$extension(SpecDSL.scala:99)

Attaching screenshots:
Failure: circe 0.9.3 is imported
vegaszeppelinfailure

Success: no circe library is imported
vegaszeppelinsuccess

I am currently working on the fix for this. vegas.spec. Spec singleton seems to be the one that requires changes. I'd like to connect with contributors/founder who wrote that code. My suggestion is to reduce the number of lines in vegas.spec. Spec by modularizing it. There are more than 2000 lines in a single file.
Any feedback?

@dankolesnikov dankolesnikov changed the title Vegas fails to work when circe 0.9.3 is imported in Zeppelin Vegas fails to work when circe 0.9.3 is imported in Zeppelin Sep 15, 2018
@dankolesnikov
Copy link
Author

@aishfenton @oshikiri

@oshikiri
Copy link
Collaborator

My suggestion is to reduce the number of lines in vegas.spec. Spec by modularizing it. There are more than 2000 lines in a single file.

core/src/main/scala/vegas/spec/Spec.scala is automatically generated by argus package (c.f. #93 and here).

@dankolesnikov
Copy link
Author

@oshikiri Updates on this:

  • It looks that argus needs to be updated to 2.8 (not released yet)
  • Assuming there is a breaking change in circe 0.7 - 0.9. Do you know of any?

@oshikiri
Copy link
Collaborator

oshikiri commented Oct 1, 2018

Assuming there is a breaking change in circe 0.7 - 0.9. Do you know of any?

I don't know about it. Could you send a pull request and check using travis-ci?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants