feat: amm spread #2379
Draft
feat: amm spread #2379
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdummett
force-pushed
the
feat/amm_spread
branch
from
52547b4
to
6faa774
Compare
cdummett
force-pushed
the
feat/amm_spread
branch
from
a073c55
to
09c4d1d
Compare
cdummett
force-pushed
the
feat/amm_spread
branch
from
faa48a3
to
4ac1f4b
Compare
|
Core work for this is done and seems to work nicely. One thing to note is that when a market enters auction the AMM's spread term is ignored and they just have the normal default spread. The reason being that the auction uncrossing code is already super complicated and prone to horrible edge cases. I don't really want to add to this complexity right now when there isn't enough resource to resolve any issues that may arise. An AMM's spread will return again once the book is uncrossed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.