Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme does not pass on to signals or text marks #459

Open
appdoo18 opened this issue Jan 20, 2022 · 1 comment
Open

Dark theme does not pass on to signals or text marks #459

appdoo18 opened this issue Jan 20, 2022 · 1 comment

Comments

@appdoo18
Copy link

Hi,
So, Vega code is imported and displayed utilizing approach #2.

So I pass in a prop for dark mode, and pass it to the "theme" component. The Vega visualization comes out great in dark mode, however, it seems that this does not pass on to the signals. Currently, working around this utilizing some css, but was wondering if this might be worked on in the future? Particularly, signals with options (ie. dropdown menu).
@domoritz
Copy link
Member

Can you provide some code to reproduce and screenshots that show the issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@domoritz @appdoo18