Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing input name #23

Open
hannahkimincompbio opened this issue May 17, 2022 · 1 comment
Open

missing input name #23

hannahkimincompbio opened this issue May 17, 2022 · 1 comment

Comments

@hannahkimincompbio
Copy link

void dump_sequence_fasta (unsigned long index, FILE* output, long firstSequenceLength, double * d = NULL, bool = false, unsigned long from = 0L, unsigned long to = 0L);

the input name is_prot is missing in this header file. It probably should be bool is_prot = false instead of bool = false.

@spond
Copy link
Member

spond commented May 17, 2022

Dear @hannahkimincompbio,

bool is_prot = false is cleaner, but C++ function declarations don't require parameter names, just parameter types. I'll add the parameter name for clarity.

Best,
Sergei

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants