Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuilding an environment may incorrectly change the code coverage type #241

Open
johnpaliotta opened this issue Nov 19, 2024 · 1 comment
Assignees

Comments

@johnpaliotta
Copy link
Contributor

When an environment is rebuilt from within the extension, the code coverage type is unconditionally set to the value of the "Coverage Kind" setting. In the case where the environment was originally built outside of VS Code this is unlikely to be the behavior the user wants/expects. Additionally, this behavior contradicts the comment for this setting which says: "Sets the coverage kind when building a new environments"

The original intent of this feature was to allow the user an easy way to update the Coverage Kind for an existing environment.

I think the following changes should be made

  1. Change "Coverage Kind" comment to be: "Sets the coverage kind when building a new environment" (drop the plural)
  2. Don't update the environment script when doing a rebuild -> should simplify code quite a bit
  3. Add a new context menu item for environment nodes to allow the user to change the Coverage Kind
    a. Ideally this would be done without having a pop-up to prompt the user for coverage kind
    1. Maybe add an "Update Coverage" command that uses the current setting value for "Coverage Kind"
      Even though this requires two steps (change setting, run command)
    2. Should be smart enough to "do no work" of the new coverage kind matches the existing coverage kind.
  4. Consider adding the additional Coverage Kinds supported by VectorCAST to the setting list (e.g. function, ...)
@aytey
Copy link
Member

aytey commented Nov 20, 2024

Ideally this would be done without having a pop-up to prompt the user for coverage kind

Is there a reason you don't want the nested level?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants