Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adopt usage of std::cell::LazyCell and std::sync::LazyLock #20950

Open
jorgehermo9 opened this issue Jul 27, 2024 · 2 comments
Open

Adopt usage of std::cell::LazyCell and std::sync::LazyLock #20950

jorgehermo9 opened this issue Jul 27, 2024 · 2 comments
Labels
meta: good first issue Anything that is good for new contributors. type: tech debt A code change that does not add user value.

Comments

@jorgehermo9
Copy link
Contributor

jorgehermo9 commented Jul 27, 2024

In Rust 1.80 (https://blog.rust-lang.org/2024/07/25/Rust-1.80.0.html) std::cell::LazyCell and std::sync::LazyLock are finally stabilized and thus they can be used instead of the variants of once_cell crate.

I think we could adopt the ones from the std and drop the usage of the once_cell crate once #20949 is merged.

We should also change this section in the STYLE.md file: https://github.com/vectordotdev/vector/blob/master/STYLE.md#global-state

@jszwedko jszwedko added type: tech debt A code change that does not add user value. meta: good first issue Anything that is good for new contributors. labels Jul 29, 2024
@moderation
Copy link

moderation commented Jul 30, 2024

Looks like there are quite a few fixes for 1.80.0 that need to occur. This is as far as I got using a conditional build of cargo build --release --verbose --no-default-features --features api,sinks-axiom,sinks-console,sinks-http,sinks-prometheus,sources-file,sources-internal_metrics,sources-journald,sources-opentelemetry,transforms-filter

@jszwedko
Copy link
Member

Rust 1.80.0 upgrade is happening here: #20949

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta: good first issue Anything that is good for new contributors. type: tech debt A code change that does not add user value.
Projects
None yet
Development

No branches or pull requests

3 participants