Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check nats stream existence in sink healthcheck #20875

Open
whatcouldbepizza opened this issue Jul 17, 2024 · 1 comment
Open

Check nats stream existence in sink healthcheck #20875

whatcouldbepizza opened this issue Jul 17, 2024 · 1 comment
Labels
sink: nats Anything `nats` sink related type: enhancement A value-adding code change that enhances its existing functionality.

Comments

@whatcouldbepizza
Copy link
Contributor

In newer versions of async_nats lib (after 0.35.1) it is promised to add functionality to search for stream by provided subject. It should be used in nats sink healthcheck when released
@whatcouldbepizza whatcouldbepizza mentioned this issue Jul 17, 2024
Merged
@jszwedko jszwedko added type: enhancement A value-adding code change that enhances its existing functionality. sink: nats Anything `nats` sink related labels Jul 17, 2024
@whatcouldbepizza
Copy link
Contributor Author

Just wanted to mention: since we can set subject dynamically, healthcheck() should be fine with subjects set by wildcards

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
sink: nats Anything `nats` sink related type: enhancement A value-adding code change that enhances its existing functionality.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jszwedko @whatcouldbepizza