-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GELF decoder's default framer with TCP input does not match the encoder's default #20768
Comments
Thanks for filing this @jorgehermo9 . I tend to agree: the encoder and decoder should by symmetric. A concern I have is that GELF clients may be delimiting with newlines because that is what the spec calls for, but they can always override it. We'd welcome a PR fif you are up for it. |
Actually, I stand corrected, the spec, as you linked to, does call for |
Thank you very much for your prompt response. I'm familiar with that code as I've been implementing #20769, and it is a very simple change. I'm pleased to submit a PR addressing this soon. |
A note for the community
Problem
As discussed in #18008, the GELF encoder was using newline delimited but graylog expected it to be '\0' delimited (https://go2docs.graylog.org/5-0/getting_in_log_data/gelf.html)
Reviewing the code, it seems that the GELF decoder is still using the newline delimiter as default in TCP inputs
vector/src/sources/socket/mod.rs
Line 123 in 3de6f0b
vector/lib/codecs/src/decoding/mod.rs
Line 337 in 3de6f0b
Should this be changed to match the encoder's default and read streaming gelf with the '\0' delimiter?
Configuration
No response
Version
0.40.0
Debug Output
No response
Example Data
No response
Additional Context
No response
References
#18008
The text was updated successfully, but these errors were encountered: