Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some file containing German Umlauts are still ISO-8859-1 encoded #7

Open
pbiering opened this issue Feb 12, 2023 · 3 comments
Open
Assignees

Comments

@pbiering
Copy link
Collaborator

as mostly all systems nowadays are UTF-8 ready, shouldn't the files which contain German Umlaus not be converted?

file -i * | egrep '(utf|iso)'
CREDITS:                  text/plain; charset=iso-8859-1
HISTORY:                  text/plain; charset=iso-8859-1
vdradmind.pl:             text/x-perl; charset=iso-8859-1

Comments?

This is also related to glenvt18/vdradmin-am#9 which has partial replacements already inside, mostly on comments, but one line is affecting the code:

-            unless ($c =~ /[<F6><E4><FC><DF><D6><C4><DC>A-Za-z0123456789_!@\$%&()+,.\-;=~ ]/) {
+            unless ($c =~ /[öäüßÖÄÜA-Za-z0123456789_!@\$%&()+,.\-;=~ ]/) {
@MegaV0lt
Copy link
Contributor

Is there a way to change this automatically?

@M-Reimer
Copy link
Member

https://perldoc.perl.org/utf8

You have to tell the interpreter that you plan to use UTF-8 in source code.

@pbiering
Copy link
Collaborator Author

I will take care of this after further testing

@pbiering pbiering self-assigned this Feb 20, 2023
@pbiering pbiering modified the milestones: v3.6.11, v3.6.12 Feb 20, 2023
@pbiering pbiering removed this from the v3.6.12 milestone Mar 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants