-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Would it be alright to store the reverse key in addition to the regular key in an exchange? #51
Comments
yes, the exchange rate crate isn't very mature right now, thanks for pointing out these issues. i noticed some PR's, will review them over the weekend. i will probably drop a new release (4.0.1) on Monday with any changes that are ready. |
That sounds good, no rush 😄 . I actually probably should add some tests anyways. |
We found that the rate for If the crate wants to align with the currency exchanges in the market, it should return |
If you store a rate for
USD -> GBP
and then you query for the rate forGBP -> USD
, you get aNone
value. This doesn't seem correct to me. Shouldn't the value returned be 1/(rate returned forUSD -> GBP
)?The text was updated successfully, but these errors were encountered: