Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offer TLS support by adding a Hitch sidecar #5

Open
ThijsFeryn opened this issue Jun 19, 2024 · 2 comments
Open

Offer TLS support by adding a Hitch sidecar #5

ThijsFeryn opened this issue Jun 19, 2024 · 2 comments
Labels
enhancement New feature or request
Milestone

Comments

@ThijsFeryn
Copy link

ThijsFeryn commented Jun 19, 2024

Please provide TLS support by adding an extra sidecar in the pod for Hitch.

  • Hitch has an official Docker image and easily be pulled in
  • The container can expose itself over port 8443 and the service can expose that over 443
  • The --backend parameter can be used to connect to Varnish, possibly over UDS instead of TCP
  • The --frontend parameter can be used to listen on port 8443 and to set the location of the TLS certificate
  • The --write-proxy-v2 flag can be enabled to communicate with Varnish using the PROXY protocol. This only works if there's an interface on Varnish that listens to PROXY traffic
  • The --alpn-protos option can be used to offer HTTP/2 support

Please also make sure the way to enable TLS matches the syntax of the Varnish Enterprise Helm Chart. This means providing the following Helm config overrides:

Thanks for considering.

@sirn
Copy link
Collaborator

sirn commented Jun 19, 2024

This is sorta supported right now with extraContainers, but we're definitely looking into adding a native support for it. The bit about certificate needs some thinking, though.

PROXY protocol is already supported via extraListens (also mentioned in the docs: https://github.com/varnish/helm-varnish-cache/tree/main/varnish-cache#extra-listens-and-extra-services).

Due to hitch being quite different from the in-core TLS offering, I'm still not sure if we should match the settings one-to-one, and opt for our standard configuration style for sidecar (server.<component>.*) instead. This way we can backport Hitch support to Enterprise as well.

No ETA on this, but it's planned.

@sirn sirn added the enhancement New feature or request label Jul 30, 2024
@sirn
Copy link
Collaborator

sirn commented Jul 30, 2024

Planned for 1.2.0

@sirn sirn modified the milestones: v1.1.0, v1.2.0 Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants