-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Varnam outputs invalid combinations with chil letters in Malayalam #166
Comments
This bug happens for anusvara ( $ varnamc -s ml -t undaavumo
ഉണ്ടാവുംോ
ഉന്ദാവുമൊ |
Interesting. Without any learnings, this is the output:
So, this has something to do with learnings, perhaps? |
Yup, it has to do with the learning. A large set of files were used for learning and looking up where the error is difficult. Still, varnam should follow the language rules, and an if condition to check if it's a chil letter will fix it. My opinion is that the tokenization should be made more better. kilivathilil should also give other options with |
Found the root of the issue. Varnam learnings has the word
Solution I'm thinking:
|
Oh. Nice catch. Seems like a good solution. How are words that end in ് dealt with? Like if പത്തരമാറ്റ് is there in word corpus and I type paththaramaattin does it do പത്തരമാറ്റ്ിന് or പത്തരമാറ്റിന്? |
…letters in Malayalam Varnam learnings has the word `kilivaathil => കിളിവാതിൽ`. When Varanm finds this word, what it does is use the word plus tokenizes the rest of it. This gives chil combinations. This PR adds a check for chil to replace the ending chil with its root consonant so that proper grammatical combinations can happen.
@asdofindia It does I changed the solution btw, it's now :
This is a better solution and less complex than the previous solution. |
This bug has been fixed in GoVarnam. GoVarnam also changed Malayalam scheme to have explicit patterns for chil (
|
Varnam outputs combinations with chil letters which is invalid in Malayalam. This seems a bug with the Malayalam scheme file (or is it ?). I can't figure out how to fix it in the scheme. This happens with some chill letters at some instances. ൽി, ർി, ള്ി ന്ി
Samples:
The text was updated successfully, but these errors were encountered: