-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3 - organize imports with eslint #657
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mathiazom
force-pushed
the
chore/v3-organize-imports
branch
from
September 17, 2024 10:07
4319902
to
23ae012
Compare
mathiazom
force-pushed
the
chore/v3-organize-imports
branch
from
September 17, 2024 10:13
6766319
to
d837790
Compare
mathiazom
force-pushed
the
chore/v3-organize-imports
branch
2 times, most recently
from
September 17, 2024 10:19
7e4d53f
to
19e6a27
Compare
anemne
reviewed
Sep 17, 2024
anemne
approved these changes
Sep 17, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me🙏
christinaroise
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated eslint configuration with various tools for organizing imports. Also improved typescript checking.
Highlights of the import rules defined in
.eslintrc.cjs
:no-relative-import-paths/no-relative-import-paths
)unused-imports/no-unused-imports
)import/order
)sort-imports
)Some rules have not been included yet, to reduce the scope of this PR. These have been mentioned in separate issues: #659 #660
Also added
npm run fix
to run linting (npm run lint
) and formatting (npm run format
) in one command.Checklist
Please ensure that you’ve completed the following checkpoints before submitting your pull request: