Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v3 - reorganize company info #654

Merged
merged 1 commit into from
Sep 17, 2024
Merged

Conversation

mathiazom
Copy link
Contributor

@mathiazom mathiazom commented Sep 16, 2024

  • Moved brand assets to separate document under Site Settings
  • Replaced default language field in Company Info with default language in Languages (under Site Settings)
  • Replaced remaining fields in Company Info with company name, org. number and contact info

Visual Overview (Image/Video)

image image

Checklist

Please ensure that you’ve completed the following checkpoints before submitting your pull request:

  • Documentation: Relevant documentation has been added or updated (if applicable).
  • Testing: Have you tested your changes thoroughly?

Copy link

vercel bot commented Sep 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
variant-no ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 1:13pm
variant-se-2 ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 16, 2024 1:13pm

@@ -14,6 +14,8 @@ import SkipToMain from "src/components/skipToMain/SkipToMain";
import { LEGAL_DOCUMENTS_QUERY } from "studio/lib/queries/legalDocuments";
import { LegalDocument } from "studio/lib/payloads/legalDocuments";
import styles from "./layout.module.css";
import { BRAND_ASSETS_QUERY } from "../../../studio/lib/queries/brandAssets";
import { BrandAssets } from "../../../studio/lib/payloads/brandAssets";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we organise our imports?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A convention for relative or absolute imports would be nice, and sorting I guess 👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it, yes

@mathiazom mathiazom merged commit 741aa87 into v3 Sep 17, 2024
6 checks passed
@mathiazom mathiazom deleted the feat/v3-reorganize-company-info branch September 17, 2024 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants