-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
id like to rename callback to redirectURL #97
Comments
Just an FYI I'm going to be doing an Imperial code sprint next week to go through all the issues and PRs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
variable representing the redirectURL, which is dictated by the oauth2 provider.
is named callback.
example:
a few router have a callbackURL, representing the same thing this hardcoded. example:
on top a function which handles the "callback" made on the "callback" sometimes referred to as "callbackURL" is named... you guessed it. "callback"
additionally callback is a reserved word, in a sense it is a descriptive term well known in IT.
for all these reasons, id like to rename it. following changes would apply
redirectURL
/redirectURI
, because it is the copied value from the oauth provider namedredirect_uri
.redirect_uri
, would be namedhandleoauthRedirect
GoogleCallbackBody.swift´, would be renamed to
GoogleOauthRedirectBody.swift`furthermore what is the background behind those static references?
the auth url could only be wrong for it would not be dictated by the provider.
this ill let be, for the moment...
all is open for discussion! please let me know what you thing, your input and thoughts.
The text was updated successfully, but these errors were encountered: