Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Display results below search bar #76

Closed
4 tasks done
Akshithsaai opened this issue Nov 1, 2024 · 14 comments · Fixed by #92
Closed
4 tasks done

Feat: Display results below search bar #76

Akshithsaai opened this issue Nov 1, 2024 · 14 comments · Fixed by #92
Assignees
Labels
enhancement New feature or request question Further information is requested

Comments

@Akshithsaai
Copy link
Contributor

Describe the feature

Whenever a user tries to search for a user on github the should be displayed with some results so that they can search easier, faster.

Similar to recommedation on google.

@vansh-codes I have worked the similar issue . I can complete ASAP.

Add ScreenShots

image

Record

  • I agree to follow this project's Code of Conduct
  • I'm GSSOC'24 Extd registered Contributor
  • I'm Hacktoberfest registered Contributor
  • I want to work on this issue
@Akshithsaai Akshithsaai added the enhancement New feature or request label Nov 1, 2024
@vansh-codes
Copy link
Owner

vansh-codes commented Nov 1, 2024

It will increase the load on the server which I think is not required, but I have a modification idea in this, can you do it for already searched users?
For example:

I came on the website for the first time and search for myself, then next-time I should get recommendation for my name so I can easily select, similarly last 5 searches should be displayed to the user on input box

Let me know if you can do this task or else feel free to close the issue

@vansh-codes vansh-codes added the question Further information is requested label Nov 1, 2024
@Akshithsaai
Copy link
Contributor Author

@vansh-codes I will think about the Idea and let you know about the implementation.

@veerendra17788
Copy link

please assign me i can do that

@Akshithsaai
Copy link
Contributor Author

@vansh-codes Check it out and suggest if any changes are there.

Gityzer.-.Google.Chrome.2024-11-09.20-30-32_compressed.mp4

@vansh-codes
Copy link
Owner

Actually we needed the suggestion type of box, when we click on input that time we should get popup kind of which we get when we fill forms and other data, this is something different :(

Can you fix it the way i am talking?

@Akshithsaai
Copy link
Contributor Author

@vansh-codes

image

Is this How you want it to be ?

@vansh-codes
Copy link
Owner

Yes, but of recently searched one only

@Akshithsaai
Copy link
Contributor Author

Akshithsaai commented Nov 9, 2024

Ok. So whenever a user types in some input , I should display related username from search history .
As far as I understood that, If I enter lets say 'I' , I should display names containing "I" from my history ryt?

@vansh-codes

@vansh-codes
Copy link
Owner

what do you mean by my history ?

suppose I visit the website for the first time, I search for vansh-codes
next time, when I click on input, i should get recommendation for vansh-codes
If i choose it gets into input box,
if I write some other username say akshithsaai then these both should come from next time, recent 5 should come maximum

@Akshithsaai
Copy link
Contributor Author

my history is like entire usernames they searched for.

But Yeah, Now I Understood what you are suggesting ,
You want to show top 5 recent searches as suggestions only if i click on the search input.

Working will be same but you want the UI and functionality changed like this ryt ? @vansh-codes

@vansh-codes
Copy link
Owner

yup!

@vansh-codes
Copy link
Owner

Do it before tomorrow 7pm to get points in gssoc-ext

@Akshithsaai
Copy link
Contributor Author

@vansh-codes Please check it out. I have made some changes.

Gityzer.-.Google.Chrome.2024-11-10.17-36-00_compressed.mp4

If we click outside the input again, Suggestions will not be shown .

Copy link
Contributor

Hello @Akshithsaai! Your issue #76 has been successfully closed. ✅ Thank you for your contribution and helping us improve the project! If you have any more ideas or run into other issues, feel free to open a new one. Happy coding! 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants