Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Adding Dockerfile for easy usage/installation of Project in any environment #60

Closed
4 tasks done
mayank-0407 opened this issue Oct 29, 2024 · 5 comments
Closed
4 tasks done
Labels
invalid This doesn't seem right

Comments

@mayank-0407
Copy link

Describe the feature

We can add a Dockerfile to easily use this project in an isolated container, and run the project with 1 command.

Add ScreenShots

image

Record

  • I agree to follow this project's Code of Conduct
  • I'm GSSOC'24 Extd registered Contributor
  • I'm Hacktoberfest registered Contributor
  • I want to work on this issue
@mayank-0407 mayank-0407 added the enhancement New feature or request label Oct 29, 2024
@vansh-codes
Copy link
Owner

Can you please explain more about it? what changes does it do? what are the advantages and how will it impact? Will there be any prerequisites for contributors after we do this?

@vansh-codes vansh-codes added the question Further information is requested label Oct 29, 2024
@mayank-0407
Copy link
Author

@vansh-codes
Adding a Dockerfile will allow the project to run in an isolated container, making setup simple and consistent. With this, contributors can start the project with just one command (docker build and docker run), minimizing dependency issues by ensuring everyone works in the same environment.

Impact: Smoother onboarding, reduced setup issues, and improved cross-system compatibility.
Prerequisites: Contributors will need Docker installed, but no other changes to the current workflow are required.

@vansh-codes
Copy link
Owner

Brother not everyone has dockers installed, even i dont have dockers installed in my system, i guess it will force the contributors to install dockers first making it more complex for them which will hinder the contribution rate in the project
You had a great idea but it doesnt aligns with the project for now
Look for other issues which I will be happy to assign
I am closing this issue for now

@vansh-codes vansh-codes added invalid This doesn't seem right and removed enhancement New feature or request question Further information is requested labels Oct 30, 2024
Copy link
Contributor

Hello @mayank-0407! Your issue #60 has been successfully closed. ✅ Thank you for your contribution and helping us improve the project! If you have any more ideas or run into other issues, feel free to open a new one. Happy coding! 🚀

@mayank-0407
Copy link
Author

@vansh-codes Adding a Dockerfile provides an optional, flexible way to run the project in an isolated container without requiring Docker for existing workflows. Contributors can continue running the project as usual or use Docker if they prefer. This setup especially helps in future scenarios, like Node.js version mismatches, ensuring a consistent environment and eliminating compatibility issues.

Impact: Docker offers smoother onboarding and cross-system compatibility, while staying optional for contributors.
Future Benefit: Docker becomes invaluable if/when dependencies like Node.js version mismatches arise, as it ensures the project runs consistently across all setups.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

2 participants