Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readonly access to trader positions based on URL #164

Open
vvp opened this issue Jul 9, 2021 · 0 comments · May be fixed by #203
Open

Readonly access to trader positions based on URL #164

vvp opened this issue Jul 9, 2021 · 0 comments · May be fixed by #203

Comments

@vvp
Copy link
Contributor

vvp commented Jul 9, 2021

I noticed some other apps are using the URL fragments to read the address/identifier to display information about the contract status (instead of using only address from the connected wallet). For example:

The biggest benefit is that as a trader, I don't need to connect my wallet to inspect my positions, which is both

  • convenient as I can check how my positions are doing just by refreshing the page (safe to assume inspecting the portfolio happens far more often than executing any trades) - especially nice with wallets that work better on desktop, so you can trade on desktop and check your portfolio on mobile
  • safer as I need to keep the wallet connected far less often which reduces the attack surface considerably

So, let's support this in Vanilla too! 🙂 I propose URLs like https://vanilladefi.com/#/portfolio/<traderaddress>.

This should not be violating any confidentiality or anonymity either, as we're still operating only public Vanilla contract data and URL fragments (basically everything after #) are processed local-only and not sent to the server. We do need to add some history management into app, which will add some complexity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant