blob/all: Don't require SetIOFSCallback to use io/fs.FS functions

vangent · Aug 21, 2024 · 1da8162 · 1da8162
1 parent d2adbc5
commit 1da8162
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 4 deletions.
diff --git a/blob/blob.go b/blob/blob.go
@@ -694,6 +694,7 @@ var NewBucket = newBucket
 func newBucket(b driver.Bucket) *Bucket {
 	return &Bucket{
 		b: b,
+		ioFSCallback: func() (context.Context, *ReaderOptions) { return context.Background(), nil },
 		tracer: &oc.Tracer{
 			Package:        pkgName,
 			Provider:       oc.ProviderName(b),

diff --git a/blob/blob_fs.go b/blob/blob_fs.go
@@ -166,9 +166,6 @@ func (b *Bucket) SetIOFSCallback(fn func() (context.Context, *ReaderOptions)) {
 //
 // SetIOFSCallback must be called prior to calling this function.
 func (b *Bucket) Open(path string) (fs.File, error) {
-	if b.ioFSCallback == nil {
-		return nil, gcerr.Newf(gcerr.InvalidArgument, nil, "blob: Open -- SetIOFSCallback must be called before Open")
-	}
 	if !fs.ValidPath(path) {
 		return nil, &fs.PathError{Op: "open", Path: path, Err: fs.ErrInvalid}
 	}

diff --git a/blob/blob_fs_test.go b/blob/blob_fs_test.go
@@ -42,7 +42,6 @@ func initBucket(t *testing.T, files []string) *blob.Bucket {
 	ctx := context.Background()
 
 	b := memblob.OpenBucket(nil)
-	b.SetIOFSCallback(func() (context.Context, *blob.ReaderOptions) { return ctx, nil })
 	for _, f := range files {
 		if err := b.WriteAll(ctx, f, []byte("data"), nil); err != nil {
 			t.Fatal(err)