Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Liquid error #6

Open
Wolfr opened this issue May 26, 2017 · 2 comments
Open

Liquid error #6

Wolfr opened this issue May 26, 2017 · 2 comments

Comments

@Wolfr
Copy link

Wolfr commented May 26, 2017

Hi. Thanks for making this available.

If I add the file to my root folder I get the following when building the Jekyll site:

Liquid Exception: Liquid syntax error (line 35): Unknown tag 'endfor' in feed.json

On the latest Jekyll 3.4.3.

Rather odd since this is a valid tag.

@Wolfr
Copy link
Author

Wolfr commented May 26, 2017

One of the PRs in this repo provides a fix.

@wkhayrattee
Copy link
Contributor

wkhayrattee commented Jun 17, 2017

hi @Wolfr , this goes beyond just a closing endif, see my pull request here: #7
Also in the meantime, @Wolfr you can use my fork here: https://github.com/7php/jekyll-json-feed

PS: Hey @vallieres please review #7 - it addresses 3 concerns.

UPDATE 01:

  • I have added a 4th commit to this to address: author (both at channel & item level) can be an object as per jsonfeed specs: https://jsonfeed.org/version/1
  • Added a 5th commit, noticed typo in enclosure_length

UPDATE 02:

  • My PR has been approved and this issue is now fixed with it.
  • @Wolfr get the latest version on master, cheers

/c @parkr FYI

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants