Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider making holiday object a first-class citizen #1712

Open
arkid15r opened this issue Mar 2, 2024 · 0 comments
Open

Consider making holiday object a first-class citizen #1712

arkid15r opened this issue Mar 2, 2024 · 0 comments
Labels

Comments

@arkid15r
Copy link
Collaborator

arkid15r commented Mar 2, 2024

The current PH version uses simple date/str pair as an item of dict-based holidays container.

Do we need/want to extend it to something more complex that would allow us having additional attributes on holiday object level (not only name, but also type/category, observance, other flags, etc)? Would the flexibility worth the efficiency trade-off (at this moment I can think of at least the new object size)?

This is based on an idea from #784 (comment). The interface example -- https://github.com/commenthol/date-holidays/blob/4596fb6c83c1339316529ae73c78e39646739488/types/index.d.ts#L55

@arkid15r arkid15r added the v1 label Mar 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant