Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v1: entity class naming #1655

Open
arkid15r opened this issue Jan 22, 2024 · 1 comment
Open

v1: entity class naming #1655

arkid15r opened this issue Jan 22, 2024 · 1 comment

Comments

@arkid15r
Copy link
Collaborator

Currently there is no standard on entity holiday class naming. In general it somehow aligns with a country name. The idea is to use unified approach on entity class naming. For iso3166 entities it could be based either on alpha-2 or alpha-3 code, e.g. UsHolidays or UsaHolidays. The classes should still be available via their alpha-2 (and probably alpha-3) code aliases so for example US() and USA() imports would also work.

@arkid15r
Copy link
Collaborator Author

See #998 (comment) for the original discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant