Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: handle backslash in font-icons when generating CSS #266

Merged
merged 1 commit into from
Oct 18, 2024

Conversation

web-padawan
Copy link
Member

@web-padawan web-padawan commented Oct 17, 2024

Description

Related to finding from vaadin/web-components#7976 (comment)

This fixes the output of CSS generator script to look like the one we had in the original repository.

Before

  html {
    --lumo-icons-align-center: '\\ea01';
    --lumo-icons-align-left: '\\ea02';
    --lumo-icons-align-right: '\\ea03';
    /* ... */
  }

After

  html {
    --lumo-icons-align-center: '\ea01';
    --lumo-icons-align-left: '\ea02';
    --lumo-icons-align-right: '\ea03';
    /* ... */
  }

Type of change

  • Bugfix

Note

Can be tested by running the following npm script:

npm run build:generate-css -w @vaadin/react-components

@web-padawan web-padawan merged commit 8569b92 into main Oct 18, 2024
2 checks passed
@web-padawan web-padawan deleted the fix/generate-font-icons branch October 18, 2024 08:55
web-padawan added a commit that referenced this pull request Oct 18, 2024
web-padawan added a commit that referenced this pull request Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants