Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New React hybrid application test module #4972

Closed
mshabarov opened this issue Jan 31, 2024 · 3 comments · Fixed by #6865
Closed

New React hybrid application test module #4972

mshabarov opened this issue Jan 31, 2024 · 3 comments · Fixed by #6865
Assignees
@caalador
Labels
feature request

Comments

@mshabarov
Copy link
Contributor

mshabarov commented Jan 31, 2024 •
edited
Loading

Describe your motivation

Add a new test module into platform and smoke tests for React hybrid application.

Existing Lit hybrid app can be used for a reference and also https://www.github.com/vaadin/flow-hilla-hybrid-example.

Additional context

Vaadin 24.4.
@mshabarov mshabarov moved this from 🟢Ready to Go to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Jan 31, 2024
@mshabarov mshabarov moved this from 🪵Product backlog to 🟢Ready to Go in Vaadin Flow ongoing work (Vaadin 10+) Feb 21, 2024
@mshabarov mshabarov moved this from 🟢Ready to Go to 🪵Product backlog in Vaadin Flow ongoing work (Vaadin 10+) Feb 28, 2024
@caalador caalador self-assigned this Oct 9, 2024
@mshabarov
Copy link
Contributor Author

mshabarov commented Oct 10, 2024 •
edited
Loading

Hybrid Test module in Platform has already some test views and one route.
These are the things that would be profitable to add:

  • FS-based routing views structure - @index.tsx and couple of views with a custom name
  • Hilla auto layout - @layout.tsx
  • Auto menus in @layout.tsx
  • Spring stateful security layer - ViewConfig for client views and annotations for server views
  • Flow main layout (can be in the same app, but with a separate url mapping)
  • Auto menus in MainLayout
  • Various navigation test cases - using React nav elements, RouterLinks, UI.navigate, forwardTo/redirectTo
  • Navigation lifecycle events handling on server: that event is triggered with expected number of times
  • Server-side API for browser navigation: History::back/forward, History::pushState/replaceState.

caalador added a commit that referenced this issue Oct 11, 2024
@caalador
feat: Add react mixed test module
cbd7325 
Add a mixed React Hilla Flow
test module to test interoperability
of the 2 features

Fixes #4972
@caalador caalador mentioned this issue Oct 11, 2024
Merged
@caalador
Copy link
Contributor

I would have security in a separate module.

caalador added a commit that referenced this issue Oct 16, 2024
@caalador
feat: Flow-Hilla with security module
f855359 
Add test module for Flow-Hilla
mixed application with security
configuration.

part of #4972
@caalador caalador mentioned this issue Oct 17, 2024
Merged
@caalador
Copy link
Contributor

Should add deep nested layouts to the non security mixed test after vaadin/hilla#2853 is merged.

mshabarov added a commit that referenced this issue Oct 24, 2024
@caalador @mshabarov
test: Add react mixed test module (#6865)
a61392e 
* feat: Add react mixed test module

Add a mixed React Hilla Flow
test module to test interoperability
of the 2 features

Fixes #4972

* update to new 24.6

* react in name and description

* fix application configuration packages.

* Use abstractPlatformTest for test base

* Remove log, fix test

* Flow to hilla navigation.

* fix menu find

* Add some navigation tests.

* Update with navigation tests.

* remove name fusion and add react instead

* Add Dashboard component

* remove index to not get issues with flow route ´flow´

* module only behind profile

---------

Co-authored-by: Mikhail Shabarov <[email protected]>
@github-project-automation github-project-automation bot moved this from ⚒️ In progress to Done in Vaadin Flow ongoing work (Vaadin 10+) Oct 24, 2024
mshabarov added a commit that referenced this issue Oct 24, 2024
@caalador @mshabarov
test: Flow-Hilla with security module (#6899)
0894b7c 
* feat: Flow-Hilla with security module

Add test module for Flow-Hilla
mixed application with security
configuration.

part of #4972

* Add views with roles.

Add tests for with and without login
for both hilla and flow main layout

* add security module

* rename profile

---------

Co-authored-by: Mikhail Shabarov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@caalador caalador

Labels
feature request
Projects
Vaadin Flow ongoing work (Vaadin 10+)
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: Add react mixed test module vaadin/platform
2 participants
@caalador @mshabarov