Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow dynamically import atmosphere.js for SW context #2901

Open
wants to merge 5 commits into
base: fix/sw-context-access
Choose a base branch
from

Fix dynamic import of atmosphere as top level await not allowed

3ba43b0
Select commit
Loading
Failed to load commit list.
Open

fix: allow dynamically import atmosphere.js for SW context #2901

Fix dynamic import of atmosphere as top level await not allowed
3ba43b0
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project failed Nov 13, 2024 in 0s

92.52% (-0.03%) compared to cf3a028

View this Pull Request on Codecov

92.52% (-0.03%) compared to cf3a028

Details

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 92.52%. Comparing base (cf3a028) to head (3ba43b0).

Files with missing lines Patch % Lines
packages/ts/frontend/src/FluxConnection.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@                    Coverage Diff                    @@
##           fix/sw-context-access    #2901      +/-   ##
=========================================================
- Coverage                  92.54%   92.52%   -0.03%     
=========================================================
  Files                         83       83              
  Lines                       2832     2836       +4     
  Branches                     732      733       +1     
=========================================================
+ Hits                        2621     2624       +3     
- Misses                       156      157       +1     
  Partials                      55       55              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.