Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(form): support non-UTC timezone date time in VaadinDateTimePicker (#2882) (CP: main) #2886

Merged
merged 3 commits into from
Nov 18, 2024

Conversation

vaadin-bot
Copy link
Collaborator

No description provided.

…#2882)

Existing for VaadinDateTimePickerStrategy failed when running in non-UTC timezone environment. This change addresses the bug and makes the form library tests always use a non-UTC timezone.
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.64%. Comparing base (36dfcff) to head (a512a77).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2886   +/-   ##
=======================================
  Coverage   92.63%   92.64%           
=======================================
  Files          83       83           
  Lines        2839     2842    +3     
  Branches      740      739    -1     
=======================================
+ Hits         2630     2633    +3     
  Misses        158      158           
  Partials       51       51           
Flag Coverage Δ
unittests 92.64% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Nov 18, 2024

@platosha platosha enabled auto-merge (squash) November 18, 2024 13:31
@platosha platosha merged commit 0a9bd31 into main Nov 18, 2024
15 checks passed
@platosha platosha deleted the cherry-pick-2882-to-main-1730391046390 branch November 18, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants