Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove installAutoSignalTracking from signals core #2818

Merged
merged 4 commits into from
Oct 22, 2024

Conversation

taefi
Copy link
Contributor

@taefi taefi commented Oct 11, 2024

#2576 had removed this before, but it was
accidentally brought back.

#2576 had removed this before, but it was
accidentally brought back.
@taefi taefi requested a review from platosha October 11, 2024 14:06
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.60%. Comparing base (e8eb0a8) to head (3ae5ef3).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2818   +/-   ##
=======================================
  Coverage   92.60%   92.60%           
=======================================
  Files          83       83           
  Lines        2812     2812           
  Branches      724      724           
=======================================
  Hits         2604     2604           
  Misses        156      156           
  Partials       52       52           
Flag Coverage Δ
unittests 92.60% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@taefi taefi marked this pull request as draft October 11, 2024 14:21
Copy link

sonarcloud bot commented Oct 22, 2024

@taefi taefi marked this pull request as ready for review October 22, 2024 13:30
@platosha platosha merged commit beeccf4 into main Oct 22, 2024
15 checks passed
@platosha platosha deleted the taefi/remove-install-auto-signal-tracking branch October 22, 2024 13:37
vaadin-bot pushed a commit that referenced this pull request Oct 22, 2024
#2576 had removed this before, but it was
accidentally brought back.

Co-authored-by: Anton Platonov <[email protected]>
platosha added a commit that referenced this pull request Nov 19, 2024
…: 24.5) (#2859)

chore: remove installAutoSignalTracking from signals core (#2818)

#2576 had removed this before, but it was
accidentally brought back.

Co-authored-by: Soroosh Taefi <[email protected]>
Co-authored-by: Anton Platonov <[email protected]>
Co-authored-by: Luciano Vernaschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants