-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add generator plugin for endpoints returning signals #2639
feat: add generator plugin for endpoints returning signals #2639
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2639 +/- ##
==========================================
+ Coverage 92.58% 92.92% +0.34%
==========================================
Files 71 72 +1
Lines 2266 2390 +124
Branches 591 611 +20
==========================================
+ Hits 2098 2221 +123
- Misses 121 122 +1
Partials 47 47
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…te-correct-endpoint-services' into taefi/enable-generator-to-generate-correct-endpoint-services
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM overall but there is some places to fix
Quality Gate passedIssues Measures |
This ticket/PR has been released with Hilla 24.5.0.alpha8 and is also targeting the upcoming stable 24.5.0 version. |
Description
The generator-plugin-signals enables the generator
to transform implementation of generated endpoints
containing methods that return a signal instances in
a way to create and return the correct signal instance
instead of Promise.
The added plugin ensures that an endpoint containing
a mixture of methods returning signal instances and
other supported types has correct implementation for
each method. It also ensures the implementation of
endpoints without any methods returning a signal
remains unchanged.
Fixes #2628
Type of change
Checklist
Additional for
Feature
type of change