-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Do not use installAutoSignalTracking #2576
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2576 +/- ##
==========================================
+ Coverage 90.71% 90.81% +0.10%
==========================================
Files 66 66
Lines 2649 2765 +116
Branches 528 528
==========================================
+ Hits 2403 2511 +108
- Misses 77 79 +2
- Partials 169 175 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Depends on vaadin/flow#19639 |
With the Flow PR, at least |
Maybe there is a better way with Karma to add
The "correct" way would be to pass the HTML files through Vite but I don't see how that would be possible |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using custom Karma HTML is OK to me. @Lodin WDYT?
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks a bit hacky to me but let's have it this way. I hope we will be able to solve it easier in #2480
#2576 had removed this before, but it was accidentally brought back.
#2576 had removed this before, but it was accidentally brought back. Co-authored-by: Anton Platonov <[email protected]>
#2576 had removed this before, but it was accidentally brought back. Co-authored-by: Anton Platonov <[email protected]>
…: 24.5) (#2859) chore: remove installAutoSignalTracking from signals core (#2818) #2576 had removed this before, but it was accidentally brought back. Co-authored-by: Soroosh Taefi <[email protected]> Co-authored-by: Anton Platonov <[email protected]> Co-authored-by: Luciano Vernaschi <[email protected]>
No description provided.