Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Do not use installAutoSignalTracking #2576

Merged
merged 3 commits into from
Jul 1, 2024
Merged

refactor: Do not use installAutoSignalTracking #2576

merged 3 commits into from
Jul 1, 2024

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jun 25, 2024

No description provided.

Copy link

codecov bot commented Jun 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.81%. Comparing base (210fae2) to head (78176cf).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2576      +/-   ##
==========================================
+ Coverage   90.71%   90.81%   +0.10%     
==========================================
  Files          66       66              
  Lines        2649     2765     +116     
  Branches      528      528              
==========================================
+ Hits         2403     2511     +108     
- Misses         77       79       +2     
- Partials      169      175       +6     
Flag Coverage Δ
unittests 90.81% <ø> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Artur-
Copy link
Member Author

Artur- commented Jun 26, 2024

Depends on vaadin/flow#19639

@Artur-
Copy link
Member Author

Artur- commented Jun 26, 2024

With the Flow PR, at least react-i18n and react-signals pass locally

@Artur- Artur- marked this pull request as ready for review June 27, 2024 16:29
@Artur- Artur- requested a review from Lodin June 27, 2024 16:29
@Artur-
Copy link
Member Author

Artur- commented Jun 27, 2024

Maybe there is a better way with Karma to add

window.$RefreshReg$ = () => {}
window.$RefreshSig$ = () => (type) => type
window.__vite_plugin_react_preamble_installed__ = true

The "correct" way would be to pass the HTML files through Vite but I don't see how that would be possible

@Artur- Artur- requested a review from platosha June 27, 2024 17:08
Copy link
Contributor

@platosha platosha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using custom Karma HTML is OK to me. @Lodin WDYT?

Copy link

sonarcloud bot commented Jul 1, 2024

Copy link
Contributor

@Lodin Lodin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks a bit hacky to me but let's have it this way. I hope we will be able to solve it easier in #2480

@Lodin Lodin merged commit c4dc4c2 into main Jul 1, 2024
15 checks passed
@Lodin Lodin deleted the signall-babel branch July 1, 2024 08:35
taefi added a commit that referenced this pull request Oct 11, 2024
#2576 had removed this before, but it was
accidentally brought back.
platosha added a commit that referenced this pull request Oct 22, 2024
#2576 had removed this before, but it was
accidentally brought back.

Co-authored-by: Anton Platonov <[email protected]>
vaadin-bot pushed a commit that referenced this pull request Oct 22, 2024
#2576 had removed this before, but it was
accidentally brought back.

Co-authored-by: Anton Platonov <[email protected]>
platosha added a commit that referenced this pull request Nov 19, 2024
…: 24.5) (#2859)

chore: remove installAutoSignalTracking from signals core (#2818)

#2576 had removed this before, but it was
accidentally brought back.

Co-authored-by: Soroosh Taefi <[email protected]>
Co-authored-by: Anton Platonov <[email protected]>
Co-authored-by: Luciano Vernaschi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants