Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rewrite preparation script in TS to avoid cross-platform issues #1938

Merged
merged 4 commits into from
Jan 9, 2024

Conversation

Lodin
Copy link
Contributor

@Lodin Lodin commented Dec 28, 2023

No description provided.

Copy link

codecov bot commented Dec 28, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (99b72a7) 95.20% compared to head (7d60176) 95.20%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1938   +/-   ##
=======================================
  Coverage   95.20%   95.20%           
=======================================
  Files          52       52           
  Lines        3483     3483           
  Branches      522      522           
=======================================
  Hits         3316     3316           
  Misses        135      135           
  Partials       32       32           
Flag Coverage Δ
unittests 95.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ZheSun88
Copy link
Contributor

summarize :

  • log some more info about which and where the generated files are

  • remove the JavaVersion: {{version}} line from hilla-versions.json

  • (?) maybe change the branch value to use platform branch instead of release tag so we dont need to update that version as hilla release is following platform

ZheSun88
ZheSun88 previously approved these changes Dec 29, 2023
Copy link
Contributor

@ZheSun88 ZheSun88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good to me

Copy link

sonarcloud bot commented Jan 9, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

1 Security Hotspot

See analysis details on SonarCloud

@Lodin Lodin enabled auto-merge (squash) January 9, 2024 11:15
@Lodin Lodin merged commit 4443dd7 into main Jan 9, 2024
15 of 16 checks passed
@Lodin Lodin deleted the refactor/prepare-sh branch January 9, 2024 14:38
@vaadin-bot
Copy link
Collaborator

Hi @Lodin and @Lodin, when i performed cherry-pick to this commit to 1.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4443dd7
error: could not apply 4443dd7... refactor: rewrite preparation script in TS to avoid cross-platform issues (#1938)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @Lodin and @Lodin, when i performed cherry-pick to this commit to 2.5, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4443dd7
error: could not apply 4443dd7... refactor: rewrite preparation script in TS to avoid cross-platform issues (#1938)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @Lodin and @Lodin, when i performed cherry-pick to this commit to 2.4, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4443dd7
error: could not apply 4443dd7... refactor: rewrite preparation script in TS to avoid cross-platform issues (#1938)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @Lodin and @Lodin, when i performed cherry-pick to this commit to 2.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4443dd7
error: could not apply 4443dd7... refactor: rewrite preparation script in TS to avoid cross-platform issues (#1938)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @Lodin and @Lodin, when i performed cherry-pick to this commit to 2.2, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4443dd7
error: could not apply 4443dd7... refactor: rewrite preparation script in TS to avoid cross-platform issues (#1938)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

@vaadin-bot
Copy link
Collaborator

Hi @Lodin and @Lodin, when i performed cherry-pick to this commit to 1.3, i have encountered the following issue. Can you take a look and pick it manually?
Error Message:
Error: Command failed: git cherry-pick 4443dd7
error: could not apply 4443dd7... refactor: rewrite preparation script in TS to avoid cross-platform issues (#1938)
hint: After resolving the conflicts, mark them with
hint: "git add/rm ", then run
hint: "git cherry-pick --continue".
hint: You can instead skip this commit with "git cherry-pick --skip".
hint: To abort and get back to the state before "git cherry-pick",
hint: run "git cherry-pick --abort".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants