Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot run build on Windows without interpreter #1639

Closed
krissvaa opened this issue Nov 2, 2023 · 1 comment
Closed

Cannot run build on Windows without interpreter #1639

krissvaa opened this issue Nov 2, 2023 · 1 comment
Assignees
@Lodin
Labels
bug Something isn't working hilla Issues related to Hilla internal improvement

Comments

@krissvaa
Copy link
Contributor

krissvaa commented Nov 2, 2023 •
edited
Loading

Describe the bug

Npm run build runs prepare.sh script which cannot be executed on Windows without WSL or GitBash or other interpreter.
And asks to install JQ as well.

Would suggestion going with js scripts which would run on any machine.

Reproduction

Run npm run build on windows machine

System Info

Windows
@krissvaa krissvaa added bug Something isn't working hilla Issues related to Hilla labels Nov 2, 2023
@Lodin Lodin self-assigned this Dec 27, 2023
@Lodin
Copy link
Contributor

Lodin commented Mar 12, 2024

Fixed via #1938

@Lodin Lodin closed this as completed Mar 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lodin Lodin

Labels
bug Something isn't working hilla Issues related to Hilla internal improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@platosha @Lodin @krissvaa