fix: multiple fast navigate calls #20446
Conversation
Fix issue where a slow connection and fast `navigate` calls throws exception due to faulty blocker state change. Fixes #20404
|
Easiest way to replicate original issue is to have a hilla layout and 2 flow layouts, setting the network throttling to slow 4g , then navigating to a flow view from a flow view through the layout menu and clicking 2 times on the menu item. |
There was a problem hiding this comment.
We talked with @platosha on Friday, this patch slightly changes how navigation works: with a slow network, when you first time click on the menu link and immediately click on the second one, the application will ignore the second navigation and basically all other navigations until the first one completes.
Maybe it's better to queue these navigations and apply the latest in the end. Flow navigation works like this IIRC.
@platosha promised to see how we can do it.
@caalador do you think it's better to queue like I described?
|
We could push the navigate to The issue is that when the programmer uses react-router |
|
There was a problem hiding this comment.
Thanks for the tip, the exception has eventually appeared for me and after the latest changes I don't see it anymore and the multiple navigations are queued and handled as I expected - the last click wins in the end.
I think we can try adding a test that simulates the same steps, I wonder if these codes works:
public class UseBlockerIT extends ChromeDeviceTest {
@Test
public void test() {
ChromeDriver driver = (ChromeDriver) getDriver();
DevTools devTools = driver.getDevTools();
devTools.send(Network.enable(Optional.empty(), Optional.empty(), Optional.empty()));
devTools.send(Network.emulateNetworkConditions(
false, // offline
100, // latency (ms)
750000, // download through (bits per second)
250000, // upload throughput (bits per second)
Optional.of(ConnectionType.CELLULAR4G), // connection type
Optional.empty(),
Optional.empty(),
Optional.empty()
));
// open a page
// click twice
// check for errors
// check the latest navigation
}
}If Flow repo is not a suitable place for it, could we add it to platform test module?
Fix issue where a slow connection
and fast
navigatecalls throwsexception due to faulty blocker
state change.
Fixes #20404