Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE REQUEST]scipy-compatibility of cho_solve #405

Open
v923z opened this issue Jun 3, 2021 · 2 comments
Open

[FEATURE REQUEST]scipy-compatibility of cho_solve #405

v923z opened this issue Jun 3, 2021 · 2 comments
Labels
enhancement New feature or request scipy compatibility a function's behaviour doesn't conform to `scipy`

Comments

@v923z
Copy link
Owner

v923z commented Jun 3, 2021

@vikas-udupa

Vikas, according to the documentation, https://docs.scipy.org/doc/scipy/reference/generated/scipy.linalg.cho_solve.html, the first argument of cho_solve is a tuple, while #391 implements it with a single matrix. I overlooked the issue at the time, but I think I would like to have scipy-compatibility. Do you want to look into this, or should I?

@v923z v923z added enhancement New feature or request scipy compatibility a function's behaviour doesn't conform to `scipy` labels Jun 3, 2021
@vikas-udupa
Copy link
Contributor

For the moment, I implemented cho_solve such that it is compatible with numpy.linalg.cholesky function that has already been implemented. But in the long run, it is right to follow what is given in the documentation, just like you mentioned.
However, I am unable to work on it at the moment due to other commitments. It would be great if you could go ahead and fix this. If not, I can fix this after a couple of weeks.

@v923z
Copy link
Owner Author

v923z commented Jun 8, 2021

@vikas-udupa OK, thanks for the feedback! I might take a stab at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request scipy compatibility a function's behaviour doesn't conform to `scipy`
Projects
None yet
Development

No branches or pull requests

2 participants