Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create documentation for supporting multi database #430

Merged
merged 2 commits into from
Jun 11, 2024
Merged

Conversation

weifanwu
Copy link

@weifanwu weifanwu commented Jun 10, 2024

Wrote the documentation to support multiple database connections (PostgreSQL, MySQL, SQLite) with DuckDB extensions.

TODO:

  • (Implement feature that supports other databases don't have DuckDB extensions yet such as BigQuery, StarRocks or SnowFlakes)

Issue: #399

@weifanwu weifanwu changed the title Create documentation for support multi database Create documentation for supporting multi database Jun 10, 2024
Copy link
Member

@jheer jheer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please see the various comments. Once addressed, this should be ready to merge.

In addition, I think this documentation should reside under /api/core/ instead of /api/duckdb/ (as the latter is specific to Mosaic's Node.js DuckDB server package).

docs/api/duckdb/multi-database-support.md Outdated Show resolved Hide resolved
docs/api/duckdb/multi-database-support.md Outdated Show resolved Hide resolved
docs/api/duckdb/multi-database-support.md Outdated Show resolved Hide resolved
docs/api/duckdb/multi-database-support.md Outdated Show resolved Hide resolved
docs/api/duckdb/multi-database-support.md Outdated Show resolved Hide resolved
docs/api/duckdb/multi-database-support.md Outdated Show resolved Hide resolved
@weifanwu weifanwu requested a review from jheer June 11, 2024 19:17
@jheer jheer merged commit c49dc53 into uwdata:main Jun 11, 2024
2 checks passed
@jheer
Copy link
Member

jheer commented Jun 11, 2024

Thanks @weifanwu!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants