Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Codebase Cleanup #155

Closed
wants to merge 1 commit into from
Closed

Codebase Cleanup #155

wants to merge 1 commit into from

Conversation

Safewaan
Copy link
Collaborator

GitHub Issue link

Remove Unused Starter Code Files

Implementation description

  • Removed some unused files

Steps to test

  1. Start the application and make sure it doesn't break

What should reviewers focus on?

  • Are there any other files/dirs that should be removed? Specifically /db-init and /hooks

Checklist

  • My PR name is descriptive and in imperative tense
  • My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
  • I have run the appropriate linter(s)
  • I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR
  • If I have made API changes, I have updated the REST API Docs
  • IF I have made changes to the db/models, I have updated the Data Models Page
  • I have updated other Docs as needed

@Safewaan Safewaan linked an issue Jul 27, 2023 that may be closed by this pull request
Remove Unused Starter Code Files #124
Open
@github-actions
Copy link

Visit the preview URL for this PR (updated for commit f2f3eab):

https://blueprintsupportivehousing--pr155-safwaan-remove-unuse-g2zgstw2.web.app

(expires Thu, 03 Aug 2023 19:51:50 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: f6bcdba7452bf82a6ec1a299c37d1bdff7870d09

owen-sellner
owen-sellner approved these changes Oct 29, 2023
View reviewed changes
Copy link
Contributor

@owen-sellner owen-sellner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The application still functions as expected with these changes. LGTM!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@owen-sellner owen-sellner owen-sellner approved these changes

@connor-bechthold connor-bechthold Awaiting requested review from connor-bechthold

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove Unused Starter Code Files
3 participants
@Safewaan @owen-sellner @connor-bechthold