From 97dded253cc43fc0d224575ebbbb617345695815 Mon Sep 17 00:00:00 2001
From: George Angel <george-angel@users.noreply.github.com>
Date: Mon, 5 Aug 2024 13:24:00 +1000
Subject: [PATCH] Use HOME envvar for identity file location

Allows simplier use with external tools like Argo
---
 age.go       |  6 ++++--
 strongbox.go | 19 ++++++++++++-------
 2 files changed, 16 insertions(+), 9 deletions(-)

diff --git a/age.go b/age.go
index 6704f4a..07c3494 100644
--- a/age.go
+++ b/age.go
@@ -19,6 +19,8 @@ const (
 	defaultIdentityFilename = ".strongbox_identity"
 )
 
+var identityFilename string
+
 func ageGenIdentity(desc string) {
 	identity, err := age.GenerateX25519Identity()
 	if err != nil {
@@ -27,7 +29,7 @@ func ageGenIdentity(desc string) {
 
 	fmt.Printf("public key: %s\n", identity.Recipient().String())
 
-	f, err := os.OpenFile(*flagIdentityFile, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
+	f, err := os.OpenFile(identityFilename, os.O_APPEND|os.O_CREATE|os.O_WRONLY, 0644)
 	if err != nil {
 		log.Fatal(err)
 	}
@@ -82,7 +84,7 @@ func ageEncrypt(w io.Writer, r []age.Recipient, in []byte, f string) {
 }
 
 func ageDecrypt(w io.Writer, in []byte) {
-	identityFile, err := os.Open(*flagIdentityFile)
+	identityFile, err := os.Open(identityFilename)
 	if err != nil {
 		// identity file doesn't exist, copy as is and return
 		if _, err = io.Copy(w, bytes.NewReader(in)); err != nil {
diff --git a/strongbox.go b/strongbox.go
index 721081c..47adbb5 100644
--- a/strongbox.go
+++ b/strongbox.go
@@ -27,7 +27,7 @@ var (
 	flagGenIdentity  = flag.String("gen-identity", "", "Generate a new identity and add it to your strongbox identity file")
 	flagGenKey       = flag.String("gen-key", "", "Generate a new key and add it to your strongbox keyring")
 	flagGitConfig    = flag.Bool("git-config", false, "Configure git for strongbox use")
-	flagIdentityFile = flag.String("identity-file", filepath.Join(os.Getenv("HOME"), defaultIdentityFilename), "strongbox identity file, if not set default '$HOME/.strongbox_identity' will be used")
+	flagIdentityFile = flag.String("identity-file", "", "strongbox identity file, if not set default '$HOME/.strongbox_identity' will be used")
 	flagKey          = flag.String("key", "", "Private key to use to decrypt")
 	flagKeyRing      = flag.String("keyring", "", "strongbox keyring file path, if not set default '$HOME/.strongbox_keyring' will be used")
 	flagRecursive    = flag.Bool("recursive", false, "Recursively decrypt all files under given folder, must be used with -decrypt flag")
@@ -78,6 +78,12 @@ func main() {
 	home := deriveHome()
 	kr = &fileKeyRing{fileName: filepath.Join(home, ".strongbox_keyring")}
 
+	if *flagIdentityFile != "" {
+		identityFilename = *flagIdentityFile
+	} else {
+		identityFilename = filepath.Join(home, defaultIdentityFilename)
+	}
+
 	// if keyring flag is set replace default keyRing
 	if *flagKeyRing != "" {
 		kr = &fileKeyRing{fileName: *flagKeyRing}
@@ -149,17 +155,16 @@ func deriveHome() string {
 	if home := os.Getenv("STRONGBOX_HOME"); home != "" {
 		return home
 	}
+	// try HOME env var
+	if home := os.Getenv("HOME"); home != "" {
+		return home
+	}
 	// Try user.Current which works in most cases, but may not work with CGO disabled.
 	u, err := user.Current()
 	if err == nil && u.HomeDir != "" {
 		return u.HomeDir
 	}
-	// try HOME env var
-	if home := os.Getenv("HOME"); home != "" {
-		return home
-	}
-
-	log.Fatal("Could not call os/user.Current() or find $STRONGBOX_HOME or $HOME. Please recompile with CGO enabled or set $STRONGBOX_HOME or $HOME")
+	log.Fatal("Could not find $STRONGBOX_HOME, $HOME or call os/user.Current(). Please set $STRONGBOX_HOME, $HOME or recompile with CGO enabled")
 	// not reached
 	return ""
 }