Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add write perm to kafka connect internal topics #742

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

fillyD
Copy link
Contributor

@fillyD fillyD commented Dec 20, 2024

No description provided.

@fillyD fillyD requested a review from a team as a code owner December 20, 2024 12:06
@uw-infra
Copy link

uw-infra commented Dec 20, 2024

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-dev-enablement
Path: dev-aws/kafka-shared-msk/dev-enablement
Commit ID: ab19f201f14a4c71229401731f2c8c76fcd31ada
✅ Run Status: Ok, Run Summary: Plan: 3 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-configs"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=dev-enablement/kafka-connect"
      + id                           = (known after apply)
      + resource_name                = "dev-enablement.connect-configs"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-offsets"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=dev-enablement/kafka-connect"
      + id                           = (known after apply)
      + resource_name                = "dev-enablement.connect-offsets"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-status"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=dev-enablement/kafka-connect"
      + id                           = (known after apply)
      + resource_name                = "dev-enablement.connect-status"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 3 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/dev-enablement as comment.

@fillyD fillyD merged commit 3e73a20 into main Dec 20, 2024
2 checks passed
@fillyD fillyD deleted the fix/add-write-to-kafka-connect-internal branch December 20, 2024 12:09
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-dev-enablement
Path: dev-aws/kafka-shared-msk/dev-enablement
Commit ID: 3e73a2036d84b5720ead25bd0dbb9631c4f01fdd
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 3 added, 0 changed, 0 destroyed
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-configs"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=dev-enablement/kafka-connect"
      + id                           = (known after apply)
      + resource_name                = "dev-enablement.connect-configs"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-offsets"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=dev-enablement/kafka-connect"
      + id                           = (known after apply)
      + resource_name                = "dev-enablement.connect-offsets"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

  # module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-status"] will be created
  + resource "kafka_acl" "producer_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Write"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=dev-enablement/kafka-connect"
      + id                           = (known after apply)
      + resource_name                = "dev-enablement.connect-status"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 3 to add, 0 to change, 0 to destroy.
module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-status"]: Creating...
module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-configs"]: Creating...
module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-offsets"]: Creating...
module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-offsets"]: Creation complete after 0s [id=User:CN=dev-enablement/kafka-connect|*|Write|Allow|Topic|dev-enablement.connect-offsets|Literal]
module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-configs"]: Creation complete after 0s [id=User:CN=dev-enablement/kafka-connect|*|Write|Allow|Topic|dev-enablement.connect-configs|Literal]
module.kafka_connect_full_internal_topics.kafka_acl.producer_acl["dev-enablement.connect-status"]: Creation complete after 0s [id=User:CN=dev-enablement/kafka-connect|*|Write|Allow|Topic|dev-enablement.connect-status|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_cert` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 3 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/dev-enablement as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants