Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

msk/account-identity: Add acc api v2 email verifier consumer #738

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

Jarota
Copy link
Contributor

@Jarota Jarota commented Dec 19, 2024

Consumer introduced in this PR

@Jarota Jarota marked this pull request as ready for review December 19, 2024 09:27
@Jarota Jarota requested a review from a team as a code owner December 19, 2024 09:27
@Jarota Jarota enabled auto-merge (squash) December 19, 2024 09:29
@Jarota Jarota disabled auto-merge December 19, 2024 09:30
@uw-infra
Copy link

uw-infra commented Dec 19, 2024

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: 76e1d2945eecd4e1e79fb598c16e6ecbef1e5fc3
✅ Run Status: Ok, Run Summary: Plan: 2 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.account_identity_account_api_v2_email_verifier.kafka_acl.group_acl["account-identity.account-api-v2-email-verifier"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_email_verifier"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-v2-email-verifier"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_v2_email_verifier.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_email_verifier"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

@uw-infra
Copy link

uw-infra commented Dec 19, 2024

Terraform run output for

Cluster: prod-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: prod-aws/kafka-shared-msk/account-identity
Commit ID: 76e1d2945eecd4e1e79fb598c16e6ecbef1e5fc3
✅ Run Status: Ok, Run Summary: Plan: 2 to add, 0 to change, 0 to destroy.
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.account_identity_account_api_v2_email_verifier.kafka_acl.group_acl["account-identity.account-api-v2-email-verifier"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_email_verifier"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-v2-email-verifier"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_v2_email_verifier.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_email_verifier"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 2 to add, 0 to change, 0 to destroy.

To manually trigger plan again please post @terraform-applier plan prod-aws/kafka-shared-msk/account-identity as comment.

@Jarota Jarota merged commit d88f571 into main Dec 19, 2024
2 checks passed
@Jarota Jarota deleted the business-email-verifier branch December 19, 2024 10:07
@uw-infra
Copy link

Terraform run output for

Cluster: dev-aws
Module: pubsub/kafka-shared-msk-account-identity
Path: dev-aws/kafka-shared-msk/account-identity
Commit ID: d88f5711c17a037a3328ccd5eb64abb1dd76e1f1
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 2 added, 0 changed, 0 destroyed
Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
  + create

Terraform will perform the following actions:

  # module.account_identity_account_api_v2_email_verifier.kafka_acl.group_acl["account-identity.account-api-v2-email-verifier"] will be created
  + resource "kafka_acl" "group_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_email_verifier"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account-api-v2-email-verifier"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Group"
    }

  # module.account_identity_account_api_v2_email_verifier.kafka_acl.topic_acl["account-identity.account.events.v2"] will be created
  + resource "kafka_acl" "topic_acl" {
      + acl_host                     = "*"
      + acl_operation                = "Read"
      + acl_permission_type          = "Allow"
      + acl_principal                = "User:CN=account-platform/account_api_v2_email_verifier"
      + id                           = (known after apply)
      + resource_name                = "account-identity.account.events.v2"
      + resource_pattern_type_filter = "Literal"
      + resource_type                = "Topic"
    }

Plan: 2 to add, 0 to change, 0 to destroy.
module.account_identity_account_api_v2_email_verifier.kafka_acl.group_acl["account-identity.account-api-v2-email-verifier"]: Creating...
module.account_identity_account_api_v2_email_verifier.kafka_acl.topic_acl["account-identity.account.events.v2"]: Creating...
module.account_identity_account_api_v2_email_verifier.kafka_acl.group_acl["account-identity.account-api-v2-email-verifier"]: Creation complete after 0s [id=User:CN=account-platform/account_api_v2_email_verifier|*|Read|Allow|Group|account-identity.account-api-v2-email-verifier|Literal]
module.account_identity_account_api_v2_email_verifier.kafka_acl.topic_acl["account-identity.account.events.v2"]: Creation complete after 0s [id=User:CN=account-platform/account_api_v2_email_verifier|*|Read|Allow|Topic|account-identity.account.events.v2|Literal]

Warning: Argument is deprecated

  with provider["registry.terraform.io/mongey/kafka"],
  on __env.tf line 12, in provider "kafka":
  12: provider "kafka" {

This parameter is now deprecated and will be removed in a later release,
please use `client_key` instead.

(and one more similar warning elsewhere)

Apply complete! Resources: 2 added, 0 changed, 0 destroyed.

To manually trigger plan again please post @terraform-applier plan dev-aws/kafka-shared-msk/account-identity as comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants