-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bring dev changes for Otel to prod #735
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Terraform run output for
✅ Run Status: Ok, Run Summary: Plan: 5 to add, 0 to change, 0 to destroy.Terraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# kafka_topic.otlp_sampled_spans will be created
+ resource "kafka_topic" "otlp_sampled_spans" {
+ config = {
+ "cleanup.policy" = "delete"
+ "compression.type" = "zstd"
+ "max.message.bytes" = "134217728"
+ "retention.bytes" = "5368709120"
+ "retention.ms" = "43200000"
+ "segment.bytes" = "262144000"
+ "segment.ms" = "10800000"
}
+ id = (known after apply)
+ name = "otel.otlp_sampled_spans"
+ partitions = 200
+ replication_factor = 3
}
# module.otel_tail_sampling_collector.kafka_acl.group_acl["otel.tail-sampling-collector"] will be created
+ resource "kafka_acl" "group_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.tail-sampling-collector"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Group"
}
# module.otel_tail_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"] will be created
+ resource "kafka_acl" "producer_acl" {
+ acl_host = "*"
+ acl_operation = "Write"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_sampled_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
# module.otel_tail_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"] will be created
+ resource "kafka_acl" "topic_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
# module.tempo_distributor.kafka_acl.topic_acl["otel.otlp_sampled_spans"] will be created
+ resource "kafka_acl" "topic_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tempo-distributor"
+ id = (known after apply)
+ resource_name = "otel.otlp_sampled_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
Plan: 5 to add, 0 to change, 0 to destroy.
|
sbuliarca
approved these changes
Dec 17, 2024
Terraform run output for
✅ Run Status: Ok, Run Summary: Apply complete! Resources: 5 added, 0 changed, 0 destroyedTerraform used the selected providers to generate the following execution
plan. Resource actions are indicated with the following symbols:
+ create
Terraform will perform the following actions:
# kafka_topic.otlp_sampled_spans will be created
+ resource "kafka_topic" "otlp_sampled_spans" {
+ config = {
+ "cleanup.policy" = "delete"
+ "compression.type" = "zstd"
+ "max.message.bytes" = "134217728"
+ "retention.bytes" = "5368709120"
+ "retention.ms" = "43200000"
+ "segment.bytes" = "262144000"
+ "segment.ms" = "10800000"
}
+ id = (known after apply)
+ name = "otel.otlp_sampled_spans"
+ partitions = 200
+ replication_factor = 3
}
# module.otel_tail_sampling_collector.kafka_acl.group_acl["otel.tail-sampling-collector"] will be created
+ resource "kafka_acl" "group_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.tail-sampling-collector"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Group"
}
# module.otel_tail_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"] will be created
+ resource "kafka_acl" "producer_acl" {
+ acl_host = "*"
+ acl_operation = "Write"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_sampled_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
# module.otel_tail_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"] will be created
+ resource "kafka_acl" "topic_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tail-sampling-collector"
+ id = (known after apply)
+ resource_name = "otel.otlp_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
# module.tempo_distributor.kafka_acl.topic_acl["otel.otlp_sampled_spans"] will be created
+ resource "kafka_acl" "topic_acl" {
+ acl_host = "*"
+ acl_operation = "Read"
+ acl_permission_type = "Allow"
+ acl_principal = "User:CN=otel/tempo-distributor"
+ id = (known after apply)
+ resource_name = "otel.otlp_sampled_spans"
+ resource_pattern_type_filter = "Literal"
+ resource_type = "Topic"
}
Plan: 5 to add, 0 to change, 0 to destroy.
module.otel_tail_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"]: Creating...
kafka_topic.otlp_sampled_spans: Creating...
module.otel_tail_sampling_collector.kafka_acl.group_acl["otel.tail-sampling-collector"]: Creating...
module.otel_tail_sampling_collector.kafka_acl.topic_acl["otel.otlp_spans"]: Creation complete after 0s [id=User:CN=otel/tail-sampling-collector|*|Read|Allow|Topic|otel.otlp_spans|Literal]
module.otel_tail_sampling_collector.kafka_acl.group_acl["otel.tail-sampling-collector"]: Creation complete after 0s [id=User:CN=otel/tail-sampling-collector|*|Read|Allow|Group|otel.tail-sampling-collector|Literal]
kafka_topic.otlp_sampled_spans: Creation complete after 1s [id=otel.otlp_sampled_spans]
module.otel_tail_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"]: Creating...
module.tempo_distributor.kafka_acl.topic_acl["otel.otlp_sampled_spans"]: Creating...
module.tempo_distributor.kafka_acl.topic_acl["otel.otlp_sampled_spans"]: Creation complete after 0s [id=User:CN=otel/tempo-distributor|*|Read|Allow|Topic|otel.otlp_sampled_spans|Literal]
module.otel_tail_sampling_collector.kafka_acl.producer_acl["otel.otlp_sampled_spans"]: Creation complete after 0s [id=User:CN=otel/tail-sampling-collector|*|Write|Allow|Topic|otel.otlp_sampled_spans|Literal]
Warning: Argument is deprecated
with provider["registry.terraform.io/mongey/kafka"],
on __env.tf line 14, in provider "kafka":
14: provider "kafka" {
This parameter is now deprecated and will be removed in a later release,
please use `ca_cert` instead.
(and 2 more similar warnings elsewhere)
Apply complete! Resources: 5 added, 0 changed, 0 destroyed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I.e. bring in equivalent changes as:
Ticket: DENA-1126