You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Mar 5, 2024. It is now read-only.
We wanted to add new labels to kiam pods and we found that adding .Values.agent.podLabels updates the .spec.selector as well as .spec.template.metadata.labels which causes us to recreate the agent daemonset.
In the server daemonset, this problem does not exist, as the server daemonset applies podLabels only on .spec.template.metadata.labels
I can send a PR to fix this, but it can potentially break users who are already using .Values.agent.podLabels as their daemonsets would need to be recreated.
The text was updated successfully, but these errors were encountered:
Sign up for freeto subscribe to this conversation on GitHub.
Already have an account?
Sign in.
We wanted to add new labels to kiam pods and we found that adding
.Values.agent.podLabels
updates the.spec.selector
as well as.spec.template.metadata.labels
which causes us to recreate the agent daemonset.This happens due to these lines
In the server daemonset, this problem does not exist, as the server daemonset applies podLabels only on
.spec.template.metadata.labels
I can send a PR to fix this, but it can potentially break users who are already using
.Values.agent.podLabels
as their daemonsets would need to be recreated.The text was updated successfully, but these errors were encountered: