Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permit let variable declarations without require sibling constraint #548

Open
5 tasks
aj-stein-nist opened this issue Feb 21, 2024 · 4 comments · May be fixed by #552
Open
5 tasks

Permit let variable declarations without require sibling constraint #548

aj-stein-nist opened this issue Feb 21, 2024 · 4 comments · May be fixed by #552
Assignees
Labels
enhancement New feature or request modeling Improvements or additions to the models/schemas

Comments

@aj-stein-nist
Copy link
Collaborator

User Story:

As a Metaschema developer, in order to share variable declarations for reuse in descendant child constraints without duplicate the same variable in every scope, I would like the Metaschema core syntax model to permit binding variable values with let but without needing to define a sibling allowed-values/expect/index/is-unique/etc. constraint beside it.

For an example as to why see PR review, specifically discussion in #542 (comment).

Goals:

Dependencies:

{Describe any previous issues or related work that must be completed to start or complete this issue.}

Acceptance Criteria

  • All website and readme documentation affected by the changes in this issue have been updated. Changes to the website can be made in the docs/content directory of your branch.
  • A Pull Request (PR) is submitted that fully addresses the goals of this User Story. This issue is referenced in the PR.
  • The CI-CD build process runs without any reported errors on the PR. This can be confirmed by reviewing that all checks have passed in the PR.

{The items above are general acceptance criteria for all User Stories. Please describe anything else that must be completed for this issue to be considered resolved.}

@aj-stein-nist aj-stein-nist added enhancement New feature or request modeling Improvements or additions to the models/schemas labels Feb 21, 2024
@aj-stein-nist aj-stein-nist self-assigned this Feb 21, 2024
@aj-stein-nist
Copy link
Collaborator Author

@david-waltermire per conversation I will leave it in 1.0.0-m3 milestone for now, we can revisit if the work gets completed and review finalized ahead of that milestone target.

aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Feb 22, 2024
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Feb 22, 2024
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Feb 23, 2024
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Feb 23, 2024
david-waltermire added a commit that referenced this issue Feb 23, 2024
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Feb 23, 2024
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Feb 23, 2024
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Feb 23, 2024
@aj-stein-nist
Copy link
Collaborator Author

Due to limited attendance at today's community meeting from Wendell and other adopters, we decided to park discussion for today and paired on other issues instead. A collection of relevant models and sample documents for further discussion will be kept in this GitHub Gist until further notice or updated to this comment.

https://gist.github.com/aj-stein-nist/3c89090184bc446b4759a41b52cf3ae3

@aj-stein-nist
Copy link
Collaborator Author

aj-stein-nist commented Mar 14, 2024

@david-waltermire, my memory is hazy on this. Have we not discussed this yet? Either way, should we be bringing it up tomorrow?

@aj-stein-nist
Copy link
Collaborator Author

Per discussion today during the community call, several on the call agreed that interleaving of <let/> with other constraints was not problematic and an acceptable implementation change. I also need to update the specification text, which I forgot about. Will update the PR accordingly and request review.

aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Mar 15, 2024
aj-stein-nist added a commit to aj-stein-nist/metaschema that referenced this issue Mar 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request modeling Improvements or additions to the models/schemas
Projects
None yet
2 participants