Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OSCAL XML schemas generated with simple data types that are not validating #181

Closed
aj-stein-nist opened this issue Sep 18, 2023 · 0 comments · Fixed by #182
Closed

OSCAL XML schemas generated with simple data types that are not validating #181

aj-stein-nist opened this issue Sep 18, 2023 · 0 comments · Fixed by #182
Assignees
Labels
bug Something isn't working
Milestone

Comments

@aj-stein-nist
Copy link
Collaborator

aj-stein-nist commented Sep 18, 2023

Describe the bug

Users utilizing v1.0.1 of the oscal-cli have reported that with example OSCAL catalogs, the official OSCAL XML Schemas for catalog and other models show errors for inline definitions of fields and flags with token data types marking elements as invalid if they have spaces (which is correct), but the CLI marks instances of these same model elements as valid with spaces when they have the same invalid spaces within them.

Who is the bug affecting?

OSCAL content authors and developers of catalog generation and management tools using liboscal-java and/or the oscal-cli.

What is affected by this bug?

Validating content based on Metaschema-defined models of OSCAL document instances.

When does this occur?

Consistently.

How do we replicate the issue?

Output of v1.1.0 OSCAL Catalog XML Schema run against reported example document: https://gist.github.com/aj-stein-nist/1aaf162735f8971d6d014870bc394b78.

With oscal-cli 1.0.1, this document will validate without errors.

Expected behavior (i.e. solution)

Similar validation errors for any token datatype instance will occur for any instance that has spaces, which are invalid for the current Metaschema token datatypes.

Other Comments

This issue has been reported to the metaschema-java maintainer and a patch has been proposed.

@aj-stein-nist aj-stein-nist added the bug Something isn't working label Sep 18, 2023
@aj-stein-nist aj-stein-nist self-assigned this Sep 18, 2023
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Sep 18, 2023
…S is enabled causing XML schema type references to not be produced for attributes associated with flags. This change restores the correct behavior by adding a type.isGeneratedType conditional check. Resolves usnistgov/liboscal-java#181.
@aj-stein-nist aj-stein-nist added this to the Next milestone Sep 18, 2023
david-waltermire added a commit to david-waltermire/metaschema-java-old that referenced this issue Sep 18, 2023
…S is enabled causing XML schema type references to not be produced for attributes associated with flags. This change restores the correct behavior by adding a type.isGeneratedType conditional check. Resolves usnistgov/liboscal-java#181.
david-waltermire added a commit to usnistgov/metaschema-java that referenced this issue Sep 18, 2023
…S is enabled causing XML schema type references to not be produced for attributes associated with flags. This change restores the correct behavior by adding a type.isGeneratedType conditional check. Resolves usnistgov/liboscal-java#181. (#218)
aj-stein-nist added a commit that referenced this issue Sep 20, 2023
Update to upcoming metaschema-java release 0.12.2 to get updated XML schema generation type signature code from usnistgov/metaschema-java#218. Fixes #181.
@aj-stein-nist aj-stein-nist linked a pull request Sep 20, 2023 that will close this issue
5 tasks
aj-stein-nist added a commit that referenced this issue Sep 20, 2023
Update to upcoming metaschema-java release 0.12.2 to get updated XML schema generation type signature code from usnistgov/metaschema-java#218. Fixes #181.
@aj-stein-nist aj-stein-nist moved this from Todo to Under Review in NIST OSCAL Work Board Sep 21, 2023
@github-project-automation github-project-automation bot moved this from Under Review to Done in NIST OSCAL Work Board Sep 21, 2023
@aj-stein-nist aj-stein-nist modified the milestones: Next, Ready, v3.0.2 Feb 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant