Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set up linkchecking #5

Closed
nikitawootten-nist opened this issue Jul 26, 2023 · 3 comments · Fixed by #22
Closed

Set up linkchecking #5

nikitawootten-nist opened this issue Jul 26, 2023 · 3 comments · Fixed by #22
Assignees
Labels
enhancement New feature or request

Comments

@nikitawootten-nist
Copy link
Collaborator

CI infrastructure should mirror the linkchecker as configured in OSCAL Pages

@nikitawootten-nist nikitawootten-nist added the enhancement New feature or request label Jul 26, 2023
@nikitawootten-nist nikitawootten-nist self-assigned this Sep 18, 2023
@nikitawootten-nist nikitawootten-nist linked a pull request Sep 18, 2023 that will close this issue
10 tasks
@nikitawootten-nist nikitawootten-nist moved this from Todo to In Progress in NIST OSCAL Work Board Sep 18, 2023
@aj-stein-nist
Copy link
Contributor

@nikitawootten-nist summarized a potential blocker in regards to how lychee handles relative links in the model reference page generation. Nikita: can you post a summary of the issue so we can post an upstream issue, whether or not we move forward with adjusting with/against it? Thanks!

@nikitawootten-nist
Copy link
Collaborator Author

Nikita: can you post a summary of the issue so we can post an upstream issue, whether or not we move forward with adjusting with/against it? Thanks!

I'll do you one better. I have a simple fix waiting to be merged now: usnistgov/metaschema-xslt#75

The problem was with a fix I made to the modeldoc pipeline, which, through a sequence of events, caused an extra upwards path traversal (../) to be inserted into relative links between reference pages. This problem was handled gracefully by NIST pages and Hugo serve, but Lychee caught it. The above PR fixes this issue and has the side effect of making relative links between pages much cleaner.

@aj-stein-nist
Copy link
Contributor

I'll do you one better.

I meant regarding the potential bug with lychee, I should have been more clear. We talked about it via Element a little so I understand better and I can file without a description here. Thanks again, I appreciate the status update today during standup.

@nikitawootten-nist nikitawootten-nist moved this from In Progress to Under Review in NIST OSCAL Work Board Sep 26, 2023
@nikitawootten-nist nikitawootten-nist moved this from Under Review to Reviewer Approved in NIST OSCAL Work Board Sep 26, 2023
@github-project-automation github-project-automation bot moved this from Reviewer Approved to Done in NIST OSCAL Work Board Sep 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants