Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GFR: Add sort logic to creators #14

Open
clingerman opened this issue Jan 24, 2017 · 1 comment
Open

GFR: Add sort logic to creators #14

clingerman opened this issue Jan 24, 2017 · 1 comment
Assignees

Comments

@clingerman
Copy link
Member

Add sort logic to creators. Try first by "Abolish Date" (putting those with none either first or last). If that is not possible, perhaps just try to sort alphabetically.

@DominicBM
Copy link
Contributor

The sort order is alphabetical now. I think logically, this might be preferable to the end dates, since there are many creators with hierarchies, and alphabetical sorting makes the organizationally similar creators appear in the same area. For example, for RG26, these three will appear in this order:

  • Department of Transportation. U.S. Coast Guard. Apalachee (Tug). 4/1/1967-4/11/1986
  • Department of Transportation. U.S. Coast Guard. Atlantic Area. Third Coast Guard District. Marine Inspection Office, Philadelphia (Pennsylvania). (7/1973 - 7/1/1987)
  • Department of Transportation. U.S. Coast Guard. Atlantic Area. U.S. Coast Guard Maintenance and Logistics Command Atlantic. 1987-3/1/2003

Sorting by end date, these would be in very different parts of the page, and I think it is unclear to the reader how they are sorted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants